Ris bxdfs example refactor#261
Merged
devshgraphicsprogramming merged 21 commits intomasterfrom Apr 18, 2026
Merged
Conversation
… to reduce shadow artifacts
| vector3_type N = objectID.shapeType == PST_SPHERE ? getSphere(objectID.id).getNormal(intersection.position) : getRectangle(objectID.id).getNormalTimesArea(); | ||
| N = hlsl::normalize(N); | ||
| intersection.geometricNormal = N; | ||
| intersection.geometricNormal = ieee754::flipSignIfRHSNegative<vector3_type>(N, hlsl::promote<vector3_type>(-hlsl::dot(N, rayIntersected.direction))); |
Member
Author
There was a problem hiding this comment.
coould have also been *sign(NdotV) before abs(NdotV)
| @@ -27,6 +27,7 @@ using sample_t = bxdf::SLightSample<ray_dir_info_t>; | |||
| using iso_cache = bxdf::SIsotropicMicrofacetCache<float>; | |||
| using aniso_cache = bxdf::SAnisotropicMicrofacetCache<iso_cache>; | |||
| using quotient_pdf_t = sampling::quotient_and_pdf<float32_t3, float>; | |||
Member
Author
There was a problem hiding this comment.
mental note, delete
| using sample_type = LS; | ||
| using spectral_type = Spectrum; | ||
| using quotient_pdf_type = sampling::quotient_and_pdf<spectral_type, scalar_type>; | ||
| using quotient_weight_type = sampling::quotient_and_pdf<spectral_type, scalar_type>; |
Member
Author
There was a problem hiding this comment.
why is it quotient_and_pdf and not quotient_and_weight ?
Comment on lines
+42
to
+43
| typename BxDF::anisocache_type _cache; | ||
| s = base_t::bxdf.generate(base_t::anisointer, u.xy, _cache); |
Member
Author
There was a problem hiding this comment.
this cache, needs to be passed to
Comment on lines
+58
to
+59
| typename BxDF::anisocache_type _cache; | ||
| s = base_t::bxdf.generate(base_t::anisointer, u, _cache); |
Comment on lines
-288
to
+296
| s = base_t::bxdf.generate(base_t::anisointer, u.xy); | ||
| typename BxDF::anisocache_type _cache; | ||
| s = base_t::bxdf.generate(base_t::anisointer, u.xy, _cache); |
Member
Author
There was a problem hiding this comment.
and here
Comment on lines
-205
to
+212
| pdf = bxdf.pdf(s, isointer); | ||
| pdf = bxdf.forwardPdf(s, isointer); |
Member
Author
There was a problem hiding this comment.
wrong signature
Comment on lines
+77
to
+78
| typename BxDF::anisocache_type _cache; | ||
| sampledLi = base_t::bxdf.quotientAndWeight(s, base_t::isointer, _cache); |
Member
Author
There was a problem hiding this comment.
dummy cache, not good
Member
Author
|
Self Assigned on material system:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@keptsecret ofl things from #224 to address in this PR: